Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: End of Service link functionality #574

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

cmaddox5
Copy link
Contributor

@cmaddox5 cmaddox5 commented Dec 2, 2024

Changed the End of service day link to increment day if current time is after 3am. Also added a new popover component so users have a description of what a service day means to us.

  • For features with a design/UX component, deployed branch to dev-green and let product know it's ready for review.

@cmaddox5 cmaddox5 requested a review from a team as a code owner December 2, 2024 21:47
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has some conflicts with the new date/time validation logic that will need to be resolved.

assets/js/components/Dashboard/PaMessageForm/MainForm.tsx Outdated Show resolved Hide resolved
@cmaddox5 cmaddox5 force-pushed the cm/update-end-of-service-link branch from 5e42b6f to 21c7fdf Compare December 5, 2024 14:36
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about how this overlaps with the date/time fields now being allowed to be temporarily in an invalid state in the code. Otherwise looks good.

@cmaddox5 cmaddox5 merged commit 4a1b8ea into main Dec 6, 2024
2 checks passed
@cmaddox5 cmaddox5 deleted the cm/update-end-of-service-link branch December 6, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants